feat(tiptap): blocks editor #1656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
commented
Nov 7, 2023
src/layouts/EditPage/EditPage.tsx
Outdated
| .focus() | ||
| .setLink({ href: selectedMediaPath }) | ||
| .run() | ||
| <BlocksContextProvider blocks={[DEFAULT_BLOCKS.text]}> |
There was a problem hiding this comment.
indentation from new context
add new variant
seaerchin
force-pushed
the
feat/preview-editor
branch
from
ee91a7d to
ef30330
Compare
harishv7
reviewed
Nov 10, 2023
| @@ -293,10 +296,11 @@ interface DraggableAccordionItemProps { | |||
| // TODO: Should get these props automatically | |||
| // rather than having us pass in manually | |||
| index: number | |||
| draggableId: string | |||
| draggableId?: string | |||
There was a problem hiding this comment.
this means not everything is draggable now?
| @@ -40,8 +40,9 @@ const PagePreview = ({ title, chunk, ...rest }) => { | |||
|
|
|||
| return ( | |||
| <Box | |||
| w="50%" | |||
| w="100%" | |||
| @@ -73,7 +73,7 @@ const getDraggableAccordionItemStyle = ({ | |||
| interface SidebarHeaderProps { | |||
There was a problem hiding this comment.
maybe can add ss in pr desc + test plan including common steps to test if all working
|
|
||
| const editor = usePreviewEditor() | ||
|
|
||
| if (!editor) return null |
There was a problem hiding this comment.
why would this happen? is it on the first paint?
| > | ||
| <IconButton | ||
| variant="clear" | ||
| isActive={curTab === "content"} |
There was a problem hiding this comment.
if there is a list of tab and ids, can we namespace it like CurTabs.content?
| </Editable.Sidebar> | ||
| </VStack> | ||
| </GridItem> | ||
| {/* Preview */} |
| TableHeader, | ||
| TableCell, | ||
| Placeholder, | ||
| CharacterCount, |
There was a problem hiding this comment.
So just to check understanding, anything with CharacterCount will be counted towards the char count displayed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: We will not be doing block editing the way this PR is done, but rather it will be integrated as part of the editor itself. Simple text editing will be done normally but complex blocks will have a border around them with a different flow for changing their contents. --@dcshzj
Problem
This PR implements a first pass block editor with draggables
Solution
Previewto aPagePreviewcomponent -> this is because we want to nest the editor inside the previeweditor-> we choose the prop preferentially over the context's; this is because we need to support multiple editors at present (:sadge:)