fix(edithomepage): move error msg extraction into component #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(homepage): fix typing * refactor(homepagepreview): merge with default values * refactor(edithomepage): empty sections on create * refactor(preview): give default values * fix(validators): fix wrong condition * refactor(validators): add simple validators that dun do extra work * refactor(hoomepage): clarify types * feat(utils): add method to compute error from state * refactor(homepage): add onblur * refactor(edithomepage): use new func to disable button * refactor(utils): rename * fix(validators): add = * refactor(edithomepaeg): remove extra prop * refactor(templates/hompage): updated props * refactor(utils): remove extra valueof * refactor(utils): refactor to return error messages --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: seaerchin <[email protected]>
* fix: nav menu template styles * fix: add spacing for legacy nav section * chore: remove unused attributes * chore: move flex into className
* chore: fix title text * chore: fix other instances of spacing
Co-authored-by: seaerchin <[email protected]>
* fix: reduce bottom padding of sidebar * fix: text styling * fix: padding on add section button * chore: remove periods from validators * chore: change placeholder text * fix: update default values of new sections * fix: copy changes
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
|
not doing this anymore - see here |
alexanderleegs
force-pushed
the
develop
branch
from
b1fb23c to
91a6fbc
Compare
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
2 similar comments
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
previously we try to extract error msg prior to data load
Solution
shift error msg extraction into component
Tests