fix(editable): change drag handle to be on top part only #1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, when we cancelled deletion of a sub-menu, there would be a cursor popping up on the button due to usage of
contentEditable
.Solution
Make only the top portion of the accordion teh drag handle. this was preferred over making the icon the drag handle as it preserves existing behaviour on production.
as users have been trained that the entire card can be dragged, we don't want to break that existing mental model. users are also unlikely to drag the body due to the large # of inputs there and small draggable area, so this is a compromise we're (me + design) is ok with for now.
Video:
old behaviour w ss
link here
new behaviour
Tests