Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editable): change drag handle to be on top part only #1475

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

seaerchin
Copy link
Contributor

Problem

Previously, when we cancelled deletion of a sub-menu, there would be a cursor popping up on the button due to usage of contentEditable.

Solution

Make only the top portion of the accordion teh drag handle. this was preferred over making the icon the drag handle as it preserves existing behaviour on production.

as users have been trained that the entire card can be dragged, we don't want to break that existing mental model. users are also unlikely to drag the body due to the large # of inputs there and small draggable area, so this is a compromise we're (me + design) is ok with for now.

Video:
old behaviour w ss
link here

new behaviour
Recording 2023-09-06 at 13 26 45

Tests

  • go to nav bar
  • add 2 sub menu
  • click on delete sub menu but cancel the deletion
  • the delete button should not have a cursor

@seaerchin seaerchin requested a review from a team September 6, 2023 05:32
@seaerchin seaerchin temporarily deployed to staging September 6, 2023 05:34 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 6, 2023 05:47 — with GitHub Actions Inactive
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seaerchin seaerchin temporarily deployed to staging September 7, 2023 03:44 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs merged commit b1fb23c into develop Sep 7, 2023
6 checks passed
@mergify mergify bot deleted the fix/draghandle branch September 7, 2023 04:22
alexanderleegs pushed a commit that referenced this pull request Sep 7, 2023
@alexanderleegs alexanderleegs mentioned this pull request Sep 7, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants