feat: introduce new version of NotFoundPage #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Lgtm for this.
One question that needs to be asked is do we know why users end up seeing this page? I think it's easy to dismiss out of hand as the users entering an invalid site but there might be valid issues at play.
Something that could help here (in follow up PR also can) is just to have a button or something that they can use to submit a bug report whilst also attaching the RUM replay id
|
@seaerchin For now this is a generic catch-all page, but I agree we should be able to include some tracking mechanism here to record the previous route that the user was on, so that it facilitates our debugging. I'll defer the design part to @sehyunidaaa since technically this PR is not part of any existing tasks, and she can look into this in greater detail when she has the time. @sehyunidaaa Pending your design review, thanks! |
|
@dcshzj fyi chromatic comment not working yet :(, you can trigger it directly via cli |
kishore03109
approved these changes
Aug 23, 2023
|
!run-chromatic |
1 similar comment
|
!run-chromatic |
|
!run-chromatic |
1 similar comment
|
!run-chromatic |
dcshzj
force-pushed
the
feat/not-found-page
branch
from
dd2a063 to
2228001
Compare
|
Reviewed, accepted on chromatic |
dcshzj
force-pushed
the
feat/not-found-page
branch
from
7c2d12a to
194b392
Compare
This was referenced Aug 30, 2023
seaerchin
added a commit
that referenced
this pull request
Aug 31, 2023
* docs(editable): add docs for drag drop stuf (#1445) Co-authored-by: seaerchin <[email protected]> * fix(editable): shift out contxt to allow nested dnd (#1448) Co-authored-by: seaerchin <[email protected]> * feat: introduce new version of NotFoundPage (#1435) * Add submarine image for NotFoundPage * Add new version of the NotFoundPage * Add storybook stories for new NotFoundPage * Fix unit test for RouteSelector * fix(ui): changes based on design feedback * IS-322 Setup GrowthBook for FE (#1449) * feat: add growthbook as dep * feat: add growthbook to app * feat: inject user attributes * feat: add default dev mode to be false * feat: inject site name as attribute * feat: add types and featur flag list * chore: minor fixes * feat: add type and conditional siteName attribute * fix: enable dev mode only for local dev * chore: remove duplicate comment * IS-417 - Fixing Selector Issues in E2E tests (#1453) * feat: update text assertion * fix: resources text assertion * fix: method to remove other collaborators * fix: uncomment code * feat: extract constant * feat: swap removeFirstCollaborator with removeOtherCollaborators * fix: use removeOtherCollaborators * chore: remove unused import and function * chore(edithomepage): shift constants out (#1416) * refactor(edithomepage): use new constants * refactor(edithomepage): shift to new folder * refactor(edithomepage): shift preview out into own section --------- Co-authored-by: seaerchin <[email protected]> * IS-508: Introduce Interface for GrowthBook (#1455) * feat: introduce interface, remove constants file * fix: comment out sample flags * ref(contactus): stylings for contact us page editor (#1458) * Enhance AddSectionButton to allow adjusting button text * Add various sections of contact us page * Adjust Editable to allow new droppable zones * Update validators to match Figma messages * Introduce feature-flagged contact us page * Remove unneeded comment * Switch to use editable contexts instead and use modal * Fix validation condition * Fix name for FeatureFlaggedContactUs * Remove some unnecessary casts * Fix RouteSelector unit test * chore: set pointerEvents to none for draggable icon button (#1456) * Feat/is 443 nav bar styling (#1457) * chore: update editable types to allow nav * feat: add pageMenuBody * feat: add resourceMenuBody * feat: add folderMenuBody * feat: add GroupMenuBody * feat: swap new components into editNavBar * chore: fix text for components * Fix: addSectionButton button text prop * chore: pass props to button instead of box * chore: add feature flag for new nav bar (#1459) * chore: add feature flag for new nav bar * fix: tests * feat(feature-flag): add feature flag from gb (#1462) * feat(feature-flag): add feature flag from gb * refactor(navbar): use gb for ff * refactor(feature-flag): add types --------- Co-authored-by: seaerchin <[email protected]> * fix(edithomepage): remove optional tags (#1450) Co-authored-by: seaerchin <[email protected]> * Feat/is 494 smooth scroll (#1439) * refactor(edithomepage): smooth scroll * fix: only scroll after first load * chore: fix rebase errors * Revert "fix: only scroll after first load" This reverts commit 158a4df. * Revert "refactor(edithomepage): smooth scroll" This reverts commit e555c2f. * fix: firstLoad condition * chore: move first load check to separate method * fix: smooth scroll --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: Alexander Lee <[email protected]> * Fix/homepage images on private repos (#1461) * chore: add util method to retrieve image path * fix: replace image retrieval in homepage template components with updated v2 endpoint * fix: change return of util method to handle nested * Update src/utils/images.ts Co-authored-by: Qilu Xie <[email protected]> * Update src/utils/images.ts Co-authored-by: Qilu Xie <[email protected]> * chore: fix styling * refactor: move image fetching to separate hook --------- Co-authored-by: Qilu Xie <[email protected]> * 0.41.0 --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: seaerchin <[email protected]> Co-authored-by: Harish <[email protected]> Co-authored-by: Hsu Zhong Jun <[email protected]> Co-authored-by: Alexander Lee <[email protected]> Co-authored-by: Qilu Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current NotFound page is outdated and the design is different from what we currently have on Figma.
This PR was also made to get familiar with the frontend codebase.
Solution
Breaking Changes
Features:
Bug Fixes:
siteNameparameter would not be present when the NotFound page is loaded (since it is loaded under a different route). This PR fixes this issue.Before & After Screenshots
BEFORE:
AFTER:
Tests
npm run tests)!run e2e)/not/found), the "Back to dashboard" button should link you to/sites./sites/zhongjun-test/notfound), the "Back to dashboard button should link you to/sites/zhongjun-test.Deploy Notes
None