-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update core deps #1054
Conversation
44af537
to
6c8cce8
Compare
6c8cce8
to
b07ce83
Compare
package.json
Outdated
"@opengovsg/design-system-react": "0.0.8", | ||
"@sentry/react": "^5.30.0", | ||
"@opengovsg/design-system-react": "0.0.12", | ||
"@sentry/react": "^7.12.1", | ||
"@sentry/tracing": "^6.15.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be upgraded too? From their migration docs:
If you installed additional Sentry packages, such as
@sentry/tracing
alongside your Sentry SDK (e.g.@sentry/react
or@sentry/node
), make sure to upgrade all of them to version 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look ok to me, but since this is quite a significant change in our packages, may I get your help to run e2e on this branch? I would feel safer approving this after running them on Cypress!
@@ -18,14 +18,18 @@ export const get = async ({ | |||
export const update = async ( | |||
siteName: string, | |||
// eslint-disable-next-line camelcase | |||
{ facebook_pixel, linkedin_insights, ...rest }: BackendSiteSettings | |||
{ | |||
facebook_pixel: pixel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is there a reason why we are using snake_case here?
If it is low effort, can we shift to camelCase instead? Else, I understand this would be out of the scope of this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't, because chromatic will fail with an eslint error here complaining about none camel cased variables. you can try this for yourself (run npm run build-storybook
) HAHAHAHA
hmm i actually omitted e2e purely because build level stuff won't fail at run time but instead, will fail to even compile. nevertheless, this is a valid point! i'll run e2e tests (and verify) for this PR |
chore(workspace): removed wip ode fix(button): changed buttons that have the isFullWidth prop to using w=100%
this is NOT WORKING due to storybook using postcss7, whereas some stuff requires postcss 8; will attempt upgrade to postcss 8 using storybook
… has everything working
put brace on single line Co-authored-by: Hsu Zhong Jun <[email protected]>
17071c4
to
bd91a19
Compare
gonna close this PR first to avoid pollution; can't find a way to make cypress work w/ webpack 5 so i think it's better to have e2e in teh meantime when we're trying to get features out rather than start from scratch (using playwright) or omitting e2e totally |
NOTE: PLEASE DELETE NODE MODULES AND DO A CLEAN INSTALL
Problem
Isomer is unable to use cool features from design system due to lacking the appropriate peer deps. This restricts engineering capability as we are either unable to build to design specs or we have to find workarounds when a ready made solution is available in design system.
this PR also fixes hmr!!!
Solution
Breaking Changes
isFullWidth
prop - this has been update to usew = 100%
.index.js
(details available here); this also removes implicitchildren
so if there's a complain aboutchildren
, this means the type needs to be wrapped inPropsWithChildren
devDeps
(see here for details)storybook-preset-craco
from addons for storybook config and replaced w/@storybook/preset-create-react-app
; the craco preset doesn't work with storybook possibly due to webpack 5 being used in storybook's new version.Visual inconsistencies
Workspace
lacks border colour (might be true for other cards inResources
andMedia
)contextMenu
colour for items is wrong for the cards ^fyi @NatMaeTan @ogpgerald
Manual verification
the commands below should still work without any issues.
please run
npm ci
prior to running these commands!!!npm run dev
npm run build-storybook
(required for chromatic deployment)npm run storybook
npm run test-e2e
npm run cypress:open