Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.42.0 #1480

Merged
merged 14 commits into from
Sep 7, 2023
Merged

Release/0.42.0 #1480

merged 14 commits into from
Sep 7, 2023

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Sep 7, 2023 •
edited
Loading

What's Changed

  • fix(editable): hover and focus states for title text #1484
  • Fix/style nits #1483
  • fix: styling #1482
  • fix(editable): change drag handle to be on top part only #1475
  • feat(editable): introduce new nested card variant #1478
  • fix(homepage): various styling fixes #1477
  • Fix/edit nav nits #1476
  • fix(edithomepage): spread properly #1474
  • Chore/fix title text #1472
  • Chore/fix edit nav bar styles #1466
  • chore(contactus): styling fixes based on design feedback #1470
  • feat: re-introduce comment-based trigger for Chromatic #1468
  • release(0.41.0): merge to develop #1463

Testing

  • Contact us
    • When creating a new location and contact information card, the default card title should no longer be in titlecase
    • The bottom padding of the general information section should now be larger
    • The guiding information underneath the feedback form URL input box should be updated
    • "Remove operating hours" should be updated to say "Delete operating hours"
    • There should be more space between the "Add operating hours" and the last operating hours card
    • The Add section button should now be slightly bigger
    • The title text in an empty section should now be centre-aligned when the title text spills over to two lines
    • The extra spacing when scrolling the sidebar all the way to the bottom should now be removed
    • The size of the accordion of a non-draggable card should now be smaller
    • The title text of the empty section placeholder now uses subhead-1 text styling
    • Navigate to the Contact Us page of a site that is using the new contact us stylings
    • Verify that the size of the nested card in Locations > Operating hours is now smaller
    • Verify that the nested card's title font colour is lighter
    • Verify that the nested card's title font colour will become darker on hover
    • Verify that expanding the nested card will have a blue border and blue background
    • Verify that dragging either the nested card or a normal accordion card will have a blue border while dragging
    • Verify that the spacing between nested cards is now smaller
  • Nav bar
    • Functionality
    • Updated styling
  • Homepage
    • Functionality
    • Updated styling

Full Changelog: v0.41.0...v0.42.0

seaerchin and others added 3 commits August 31, 2023 15:57
@seaerchin
Merge pull request #1463 from isomerpages/release/v0.41.0
415c6dc 
release(0.41.0): merge to `develop`
@dcshzj
feat: re-introduce comment-based trigger for Chromatic (#1468)
8953a6f
@dcshzj
chore(contactus): styling fixes based on design feedback (#1470)
a71e8da 
* chore(contactus): styling fixes based on design feedback

* fix: use subhead-1 styling instead

* chore: remove unused import
@alexanderleegs alexanderleegs mentioned this pull request Sep 7, 2023
Merged
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 02:20 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 02:21 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 02:22 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 02:23 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 02:28 — with GitHub Actions Inactive
alexanderleegs and others added 7 commits September 7, 2023 12:29
@alexanderleegs
Chore/fix edit nav bar styles (#1466)
97b4235 
* fix: nav menu template styles

* fix: add spacing for legacy nav section

* chore: remove unused attributes

* chore: move flex into className
@alexanderleegs
Chore/fix title text (#1472)
efb7aee 
* chore: fix title text

* chore: fix other instances of spacing
@seaerchin @alexanderleegs
fix(edithomepage): spread properly (#1474)
58735cd 
Co-authored-by: seaerchin <[email protected]>
@alexanderleegs
Fix/edit nav nits (#1476)
6dfffe4 
* fix: reduce bottom padding of sidebar

* fix: text styling

* fix: padding on add section button

* chore: remove periods from validators

* chore: change placeholder text

* fix: update default values of new sections

* fix: copy changes
@seaerchin @alexanderleegs
fix(homepage): various styling fixes (#1477)
b17a1e5 
* fix(edithomepage): fixed spacing between card/button

* fix(editable): fixed styling

* fix(editable): updated padding of editable accordion button

* fix(hero-highlight): fixed copy

* fix(editable): update padding

* fix(hero-higihlihgt-section): update wording

* refactor(formmediainput): add width

* fix(editable): fixed border radius on hover

---------

Co-authored-by: seaerchin <[email protected]>
@dcshzj @alexanderleegs
feat(editable): introduce new nested card variant (#1478)
fabf409 
* feat(icons): introduce new vertical draggable icon

* feat(editable): introduce nested version of accordion

* fix(contactus): update location card to use nested

* fix: border radius of error divider
@seaerchin @alexanderleegs
fix(editable): change drag handle to be on top part only (#1475)
91a6fbc 
Co-authored-by: seaerchin <[email protected]>
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 04:48 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 04:49 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 05:10 — with GitHub Actions Inactive
@seaerchin
fix: styling (#1482)
7185abc 
* fix(components): add isNested

* fix(editable): fix boxshadow beign on box

* fix(cards): remove full wdith

* fix(infopic): full width input

---------

Co-authored-by: seaerchin <[email protected]>
@mergify
Copy link

mergify bot commented Sep 7, 2023

⚠️ The sha of the head commit of this PR conflicts with #1481. Mergify cannot evaluate rules on this PR. ⚠️

@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 06:08 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 06:09 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 06:10 — with GitHub Actions Inactive
@seaerchin
Fix/style nits (#1483)
5470322 
* fix(nested-cards): fix spacing to 0.75rem

* fix(editable): set extra padding

* fix(edithoempage): fix errors

* fix(cardssection): remove errorneous spacing

* fix(cards): remove extra margins

* fix(hero/infopic): update margins

* fix(editable): remove padding

---------

Co-authored-by: seaerchin <[email protected]>
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 07:36 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 07:37 — with GitHub Actions Inactive
@alexanderleegs alexanderleegs merged commit 71474fe into master Sep 7, 2023
20 checks passed
@alexanderleegs alexanderleegs temporarily deployed to staging September 7, 2023 07:38 — with GitHub Actions Inactive
@mergify mergify bot deleted the release/0.42.0 branch September 7, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderleegs @seaerchin @dcshzj