feat: add type and conditional siteName attribute

isomerpages · Aug 27, 2023 · 95d97be · 95d97be
1 parent 3676e12
commit 95d97be
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/src/routing/ProtectedRoute.tsx b/src/routing/ProtectedRoute.tsx
@@ -10,6 +10,8 @@ import { useLoginContext } from "contexts/LoginContext"
 import { getDecodedParams } from "utils/decoding"
 import { getSiteNameAttributeFromPath } from "utils/growthbook"
 
+import { GBAttributes } from "types/featureFlags"
+
 // axios settings
 axios.defaults.withCredentials = true
 
@@ -34,17 +36,23 @@ export const ProtectedRoute = ({
   } = useLoginContext()
   const growthbook = useGrowthBook()
   const currPath = useLocation().pathname
+  const siteNameFromPath = getSiteNameAttributeFromPath(currPath)
 
   useEffect(() => {
-    if (growthbook)
-      growthbook.setAttributes({
+    if (growthbook) {
+      const gbAttributes: GBAttributes = {
         userId,
         userType,
         email,
         displayedName,
         contactNumber,
-        siteName: getSiteNameAttributeFromPath(currPath),
-      })
+      }
+      // add siteName if it exists
+      if (siteNameFromPath && siteNameFromPath !== "") {
+        gbAttributes.siteName = siteNameFromPath
+      }
+      growthbook.setAttributes(gbAttributes)
+    }
   }, [userId, userType, email, displayedName, contactNumber, currPath])
 
   if (isLoading) {

diff --git a/src/types/featureFlags.ts b/src/types/featureFlags.ts
@@ -11,3 +11,12 @@ export type FeatureFlag = {
   key: string
   type: FeatureFlagTypes
 }
+
+export type GBAttributes = {
+  userId: string
+  userType: string
+  email: string
+  displayedName: string
+  contactNumber: string
+  siteName?: string
+}