Feat/move files #124
Merged
Feat/move files #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 8, 2021
Closed
kwajiehao
suggested changes
Mar 9, 2021
| const collections = await IsomerCollection.list() | ||
|
|
||
| // Check if collection already exists | ||
| if (!collections.includes(targetCollectionName) && targetCollectionName !== 'pages') { |
There was a problem hiding this comment.
Also check that target collection name is not one of the ISOMER_TEMPLATE_DIRS
There was a problem hiding this comment.
As discussed offline, we will check for any of the protected folder names created by jekyll regardless of whether they are prepended with an underscore. This check has been added to the create method in the Collection class in fde311c, while pages will continue to be used to indicate a move to unlinked pages.
alexanderleegs
force-pushed
the
feat/move-files
branch
from
4d1f85f to
c600e85
Compare
|
As discussed offline, we will be extending the |
kwajiehao
added a commit
to isomerpages/isomercms-frontend
that referenced
this pull request
Mar 23, 2021
Thanks to PR #124 on the backend isomerpages/isomercms-backend#124, we can simplify the file-moving logic in `OverviewCard` since `OverviewCard` is now used only for unlinked pages in the workspace (it is also used for Resource Category display, but these do not have any move file functionality). This allows us to remove all the complex logic associated with file-moving and replace it with a single API call to the new file moving endpoint. This also allows us to delete the now-unused util function `saveFileAndRetrieveUrl`.
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Nit: config indentation * Feat: update list for collection to not use _config.yml file * Refactor: use new list method when retrieving folders * Feat: add page moving endpoints for collections and unlinked pages * Fix: missing import in config class * Feat: add check for special directory names * Feat: add third nav parameter to front matter * Fix: remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new endpoints to handle the moving of multiple files from one folder to another. To be reviewed in conjunction with PR #369 on the isomercms-frontend repo.
In addition, this PR also updates the existing list() method of collections to work with both the existing format as well as the file format post jekyll 4.0 update.
Resolves issues #116 and #120