This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
feat(cleanup): remove redundant conf file #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
force-pushed
the
staging
branch
from
1889bde to
da332a9
Compare
kishore03109
commented
Dec 26, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ### Introduction | |||
|
|
|||
There was a problem hiding this comment.
bunch of prettier changes
kishore03109
commented
Dec 26, 2023
| to certbot's internal web service. This allows certbot to prove to LetsEncrypt | ||
| that Isomer has control of the domain that we are requesting a certificate for, | ||
| via an [HTTP-01 challenge](https://letsencrypt.org/docs/challenge-types/). | ||
|
|
||
| Custom SSL certificates are still supported by adding nginx server config blocks |
There was a problem hiding this comment.
Note to reviewer: Main change is here, since we are no longer supported custom certs moving forward
kishore03109
commented
Dec 26, 2023
| @@ -1,8 +0,0 @@ | |||
| server { | |||
There was a problem hiding this comment.
Note: tax academy already have another conf file here
seaerchin
approved these changes
Dec 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up, remove support for custom certs, this is a preparation for dry run tomorrow