Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csl fix #134

Merged
merged 3 commits into from
Mar 5, 2021
Merged

csl fix #134

merged 3 commits into from
Mar 5, 2021

Conversation

ismayc
Copy link
Owner

@ismayc ismayc commented Mar 5, 2021

No description provided.

@mirh
Copy link

mirh commented Mar 11, 2021

You should future proof this slightly more, or the latest pandoc version isn't happy
(it complains "\vadjust cannot be used in vertical mode") jgm/pandoc@356795d

@ismayc
Copy link
Owner Author

ismayc commented Mar 11, 2021

What do you suggest?

@mirh
Copy link

mirh commented Mar 12, 2021

From the linked commit, fix number of parameters on CSLReferences, or pandoc 2.12 won't like it.

@ismayc
Copy link
Owner Author

ismayc commented Mar 12, 2021

Agreed, but what if someone doesn't have pandoc 2.12? How do you suggest future proofing for those that haven't updated as well?

@mirh
Copy link

mirh commented Mar 12, 2021

Pandoc had already switched to it in 2.11.2, and even 2.11 seems to work just fine with [2].

@ismayc
Copy link
Owner Author

ismayc commented Mar 12, 2021

Alright, we'll try it out! #137

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org whenever possible) and link to this issue. If a reprex is not applicable, recording a short Loom video showing what you are seeing can go a long way in helping to diagnose problems.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants