Implement new functions in LegoAnimManager
#1170
Open
+49
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonschz
changed the title
LegoAnimManager
foxtacles
reviewed
Nov 26, 2024
| // FUNCTION: LEGO1 0x1004b830 | ||
| MxBool LegoAnimMMPresenter::FUN_1004b830() | ||
| { | ||
| return !(m_unk0x58 < 6); |
There was a problem hiding this comment.
I think writing this as: m_unk0x58 >= e_unk6 is clearer - m_unk0x58 is some sort of state progression and this checks that it is in e_unk6 or later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new functions match correctly, but
FUN_100604f0seems to be susceptible to entropy - it matches to 100 % on BETA10 and it looks correct on LEGO1.