Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redesign takes the concept of argpacks and extends it generally to step arguments as well as hpc arguments.
SubmitArgpacks.py
hosts the generalized implementation andHpcArgpacks.py
contains the hpc-specifics both for formatting as well as config structure.option : {}
whereoption
is the flag to use and any further optional hpc resource specifications should be entered into the{}
option
dictionary are considered both the resource name and an argpack. If regex argpacks are used here, at hpc submission time they will be sanitized to only use the base argpack nameNaturally, the join and override command line options must be updated.
The command line join under the hood has been entirely reworked to aggregate resources based on expected runtimes, much like the step thread pool. This differs from the original implementation of just taking the top N resources where N is the pool size.
The override input to the join command no longer expects a resource string as input into the config. The input SHOULD still mirror the config input, however. Instead, the input is now the equivalent of the json dictionary in the config. Argpacks referenced need only use the basename of the argpack (no regex syntax) since at final join uniqueness is maintained and regexes stripped