Resource allocation multistep #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 Added the ability to multithread steps, but only takes the aggregate of all runnable steps to be the max resources, without accounting for the size of the threadpool.
These changes walk through slightly similar logic to the tests' pool simulation, accounting for instantaneous max resources used based on provided timelimit of that action. For steps the additional complexity comes from dependency tracking whereas tests are independent.
Step max resource allocation is now based on instantaneous consumption of resources from the running of steps in the order prescribed by the test config and any dependencies when steps are run for the exact timelimit assigned.