chore(j-s): Update lawyer filtering for litigators

[unakb]

Asana

What

Change how we filter out lawyers that are classified as possible litigators in indictment cases

Why

Because this way is more accurate

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Updated the filtering logic for lawyer listings to enhance the accuracy of results based on lawyer type. This improvement ensures users receive more relevant lawyer data, contributing to a more reliable and user-friendly directory experience.

[coderabbitai]

Walkthrough

The change updates the query parameter in the getLawyers method within the LawyersService class. When the lawyerType is LawyerType.LITIGATORS, the method now appends '?verjendur=1' to the API URL instead of the previous '?isCorporate=0'. All other logic, including error handling and response processing, remains unchanged.

Changes

File	Change Summary
libs/judicial-system/.../lawyers.service.ts	Updated query parameter in getLawyers: switched from appending '?isCorporate=0' to '?verjendur=1' when lawyerType is LITIGATORS.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant LS as LawyersService
    participant API as Lawyer Registry API

    C->>LS: Request getLawyers(lawyerType)
    alt lawyerType is LITIGATORS
        LS->>API: GET /lawyers?verjendur=1
    else
        LS->>API: GET /lawyers
    end
    API-->>LS: Return response
    LS-->>C: Return processed response

Loading

Possibly related PRs

• feat(j-s): Get litigators from lawyer registry #15272: Modifies the getLawyers method to accept a lawyerType parameter, indicating a closely related change in handling lawyer types.

Suggested labels

automerge

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9da8a34 and ff2c0ee.

📒 Files selected for processing (1)

• libs/judicial-system/lawyers/src/lib/lawyers.service.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• libs/judicial-system/lawyers/src/lib/lawyers.service.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ff2c0ee.

Command	Status	Duration	Result
nx run-many --projects judicial-system-digital-...	✅ Succeeded	1s	View ↗
nx run-many --target=codegen/frontend-client --...	✅ Succeeded	13s	View ↗
nx run-many --target=codegen/backend-schema --a...	✅ Succeeded	24s	View ↗
nx run-many --target=build --projects=judicial-...	✅ Succeeded	15s	View ↗
nx run-many --target=lint --projects=judicial-s...	✅ Succeeded	1s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-02-05 15:10:03 UTC