fix(app-sys): update regex for contentful namespaces #17783
Conversation
WalkthroughThe changes modify the namespace validation in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
View your CI Pipeline Execution ↗ for commit 2301b99.
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
libs/application/core/src/validation/validators.ts (1)
30-30: Consider a more specific regex pattern.While the current pattern works, we could make it more specific to prevent potential misuse.
Consider this alternative pattern that enforces stricter rules:
- const namespaceRegex = /^[\w.]+:\w+(\.\w+)*$/g + const namespaceRegex = /^[a-z][\w]*(?:\.[a-z][\w]*)*:[a-z][\w]*(?:\.[a-z][\w]*)*$/gThis pattern:
- Enforces segments to start with lowercase letters
- Maintains camelCase convention
- Prevents consecutive dots
- Ensures cleaner namespace structure
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/application/core/src/validation/validators.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/application/core/src/validation/validators.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: prepare
What
Allow custom zod validation messages for nested applications
Why
The regex for the namespace in contentfull didn't match to applications in nested folders, like aosh
Checklist:
Summary by CodeRabbit