Better AssertJ usage #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use BDD style assertions (then instead of assertThat) Generate custom assertions for ToDoItem and PropertyDomainEvent. Generated assertions entry point : Assertions and BddAssertions Add generated assertions in src/test/java/todoapp/integtests/assertions/ Comment AssertJ assertions generator plugin addition in pom.xml to ease future usage.
danhaywood
added a commit
that referenced
this pull request
Apr 23, 2015
|
Many thanks, Joel. I've merged this change to a branch, and pushed, but have decided to it unmerged with master... see https://github.com/isisaddons/isis-app-todoapp#usage-of-assertj as to why. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit shows standard AssertJ assertions improvements.
Second commit shows:
thenreplaceassertThat)I only have created assertions for
ToDoItemandPropertyDomainEvent.I wanted to show how to use the domain language in assertions.