Skip to content

Commit

Permalink
Fix build for linux python wheel (microsoft#22801)
Browse files Browse the repository at this point in the history
### Description
Fixes command for building Linux python packages by preventing an empty
`-p` command-line option from being passed to a subsequent build script:
https://github.com/microsoft/onnxruntime/blob/1f3b675453e8412e5c084bfb95997967d0c2eec2/tools/ci_build/github/linux/run_python_dockerbuild.sh#L37



### Motivation and Context
A recent [PR
](microsoft#22773 a new
optional command-line option (`-p`) to pass custom python exe paths. We
need to check if the option is empty before forwarding the option to a
separate build script.
  • Loading branch information
adrianlizarraga authored and Ishwar Raut committed Nov 19, 2024
1 parent 43b042b commit 6238ff1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion tools/ci_build/github/linux/run_python_dockerbuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ done
mkdir -p "${HOME}/.onnx"
DOCKER_SCRIPT_OPTIONS="-d ${DEVICE} -c ${BUILD_CONFIG}"

if [ "${PYTHON_EXES}" != "" ] ; then
DOCKER_SCRIPT_OPTIONS+=" -p ${PYTHON_EXES}"
fi

if [ "${BUILD_EXTR_PAR}" != "" ] ; then
DOCKER_SCRIPT_OPTIONS+=" -x ${BUILD_EXTR_PAR}"
fi
Expand All @@ -34,7 +38,7 @@ docker run --rm \
-e ORT_DISABLE_PYTHON_PACKAGE_LOCAL_VERSION \
-e DEFAULT_TRAINING_PACKAGE_DEVICE \
$ADDITIONAL_DOCKER_PARAMETER \
$DOCKER_IMAGE tools/ci_build/github/linux/build_linux_python_package.sh -c $BUILD_CONFIG -p $PYTHON_EXES $DOCKER_SCRIPT_OPTIONS
$DOCKER_IMAGE tools/ci_build/github/linux/build_linux_python_package.sh $DOCKER_SCRIPT_OPTIONS

sudo rm -rf "${BUILD_BINARIESDIRECTORY}/${BUILD_CONFIG}/onnxruntime" "${BUILD_BINARIESDIRECTORY}/${BUILD_CONFIG}/pybind11" \
"${BUILD_BINARIESDIRECTORY}/${BUILD_CONFIG}/models" "${BUILD_BINARIESDIRECTORY}/${BUILD_CONFIG}/_deps" \
Expand Down

0 comments on commit 6238ff1

Please sign in to comment.