Don't allow inserting empty equations #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the model free of invisible empty equation tags
|
@Jules-Bertholet Thank you! I didn't notice this PR until now, I will look at this ASAP (today / tomorrow ideally) Do you want/need this backported to an earlier ckeditor version also, e.g. 26 / 27.0? |
|
I don't need this backported, no |
|
@Jules-Bertholet Released in 27.1.3 |
Jules-Bertholet
pushed a commit
to Jules-Bertholet/ckeditor5-math
that referenced
this pull request
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugin allows inserting empty equations. These are invisible, but are stored in the model/view as useless junk. This PR prevents this