Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation documentation fixes #9

Merged
merged 6 commits into from
Nov 14, 2022
Merged

Keyboard navigation documentation fixes #9

merged 6 commits into from
Nov 14, 2022

Conversation

isabela-pf
Copy link
Owner

This is a running PR of fixes to the keyboard navigation workshop documentation. As we test the events and/or get feedback, I'll add commits.

This can be merged whenever the fixes need to go live.

🌻

@isabela-pf
Copy link
Owner Author

isabela-pf commented Nov 11, 2022

Feedback from the first event #10

  • Need to add space for general notes or things that could impact all tests.
  • Having common language to reference could also be helpful.
  • Maybe this should be on hackmd instead; leverage real RTC?
  • Add table of contents to top maybe? To help guide?
  • Review might be better split by view (ie. what is open, where) or UI region rather than test running over all of it.
  • Maybe add takeaways as an area to fill out per section. I did this manually post-event for the issue it created to make it action-focused. I'm torn because part of me thought it was good I really had to read and synthesize all the feedback because as the person opening this issue I think I need be aware what I'm posting. It also slowed down the transition though, which could become a big problem as we run more events.

Good things!

  • Binder made it easy!
  • Table placeholders were helpful!

@isabela-pf
Copy link
Owner Author

I want to give this self-review with fresh eyes, so I'm moving it out of draft for later.

@isabela-pf isabela-pf marked this pull request as ready for review November 11, 2022 21:54
@isabela-pf
Copy link
Owner Author

I think this is good enough pass. I'll pat myself on the back and schedule another prototype meeting to keep trying out this work.

@isabela-pf isabela-pf merged commit 8b72631 into main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant