correctly readlink() when in multiply-nested symlink dirs

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 1.9
 
 - Add `path` for compatibility with Node v20 Dirent
+- Correctly readlink() in multiply nested symlink directories
 
 ## 1.8
 

src/index.ts

@@ -860,7 +860,7 @@ export abstract class PathBase implements Dirent {
     /* c8 ignore stop */
     try {
       const read = await this.#fs.promises.readlink(this.fullpath())
-      const linkTarget = this.parent.resolve(read)
+      const linkTarget = (await this.parent.realpath())?.resolve(read)
       if (linkTarget) {
         return (this.#linkTarget = linkTarget)
       }
@@ -889,7 +889,7 @@ export abstract class PathBase implements Dirent {
     /* c8 ignore stop */
     try {
       const read = this.#fs.readlinkSync(this.fullpath())
-      const linkTarget = this.parent.resolve(read)
+      const linkTarget = (this.parent.realpathSync())?.resolve(read)
       if (linkTarget) {
         return (this.#linkTarget = linkTarget)
       }

test/index.ts

@@ -1617,3 +1617,28 @@ t.test('chdir', async t => {
     expect
   )
 })
+
+t.test('link targets in multiply nested symlinks', async t => {
+  const cwd = t.testdir({
+    dir_baz: {
+      bar: t.fixture('symlink', '../dir_bar'),
+    },
+    dir_bar: {
+      foo: t.fixture('symlink', '../dir_foo'),
+    },
+    dir_foo: {
+      'foo.txt': 'hello'
+    }
+  })
+  t.test('async', async t => {
+    const p = new PathScurry(cwd)
+    const link = p.cwd.resolve('./dir_baz/bar/foo')
+    t.ok(await (await link.readlink())?.lstat(), 'found the link target')
+  })
+  t.test('sync', t =>  {
+    const p = new PathScurry(cwd)
+    const link = p.cwd.resolve('./dir_baz/bar/foo')
+    t.ok(link.readlinkSync()?.lstatSync(), 'found the link target')
+    t.end()
+  })
+})