Skip to content

Commit

Permalink
remove undocumented 'ended' getter
Browse files Browse the repository at this point in the history
Caused a regression in any modules using 'ended' themselves.
  • Loading branch information
isaacs committed Sep 23, 2019
1 parent 320eb57 commit 40e1d61
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,6 @@ class Minipass extends EE {
return this[EMITTED_END]
}

get ended () {
return this[EMITTED_END]
}

[MAYBE_EMIT_END] () {
if (!this[EMITTING_END] &&
!this[EMITTED_END] &&
Expand Down
1 change: 0 additions & 1 deletion test/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ t.test('write after end', async t => {
mp.on('end', _ => sawEnd++)
mp.end() // empty
t.ok(mp.emittedEnd, 'emitted end event')
t.ok(mp.ended, 'emitted end event')
t.throws(_ => mp.write('nope'))
t.equal(sawEnd, 1, 'should get end event (empty stream)')
mp.resume()
Expand Down

0 comments on commit 40e1d61

Please sign in to comment.