Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 - placeholder in origin zone when dragged outside of any and origin zone min dimensions control #202

Merged
merged 6 commits into from
Dec 24, 2020

Conversation

isaacHagoel
Copy link
Owner

basic implementation. incomplete (see TODO items). makes the placeholder appear in the origin zone when it is outside of any. not optional
resolves #201

…aceholder appear in the origin zone when it is outside of any. not optional
…there for the duration of the drag operation to avoid no dragged left event when taking the last item out (it also results in a better ux). removed un-needed special handling for dropped outside of any which was adding the shadow item back to the original list before animating the dragged element to place
…ne styles), restoring original values (including undefined which effectively removes them) on drop
@isaacHagoel isaacHagoel marked this pull request as ready for review December 24, 2020 03:09
@isaacHagoel isaacHagoel changed the title 201 - basic implementation. incomplete (see TODO items). makes the pl… 201 - placeholder in origin zone when dragged outside of any and origin zone min dimensions control Dec 24, 2020
@isaacHagoel isaacHagoel merged commit 2481aff into master Dec 24, 2020
@isaacHagoel isaacHagoel deleted the 201-placeholder-when-outside-of-any branch December 24, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when dragged is outsize of all dnd zones show the placeholder in the origin zone in the origin index
1 participant