generated from isXander/FabricKotlinTemplate
-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MC-17738 Fix #361
Open
MaxenceDC
wants to merge
1
commit into
isXander:1.20
Choose a base branch
from
MaxenceDC:1.20
base: 1.20
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MC-17738 Fix #361
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
src/main/java/dev/isxander/debugify/mixins/basic/mc177831/LocateDistanceMixin.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package dev.isxander.debugify.mixins.basic.mc177831; | ||
|
||
import dev.isxander.debugify.fixes.BugFix; | ||
import dev.isxander.debugify.fixes.FixCategory; | ||
import net.minecraft.server.commands.LocateCommand; | ||
import org.spongepowered.asm.mixin.Mixin; | ||
import org.spongepowered.asm.mixin.Overwrite; | ||
|
||
@BugFix(id = "MC-177831", category = FixCategory.BASIC, env = BugFix.Env.SERVER) | ||
@Mixin(LocateCommand.class) | ||
public class LocateDistanceMixin { | ||
/** | ||
* @author MaxenceDC | ||
* @reason Fix MC-177831 | ||
*/ | ||
@Overwrite | ||
private static float dist(int pos1x, int pos1z, int pos2x, int pos2z) { | ||
double delta_x = pos2x - pos1x; | ||
double delta_y = pos2z - pos1z; | ||
return (float) Math.hypot(delta_x, delta_y); // Math.hypot accounts for integer overflow, with error upto 1ulp | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,7 @@ | |
"debugify.fix_explanation.mc-89146": "Provides a strict save order of tile entities, to match the update order which then allows initial update of tile entities to be in the correct order.", | ||
"debugify.fix_explanation.mc-93018": "Only initiate breeding if the wolf is tamed.", | ||
"debugify.fix_explanation.mc-100991": "Notifies the damage tracker of a thrown fishing hook damaging the entity with 0 damage, like snowballs.", | ||
"debugify.fix_explanation.mc-177381": "The /locate command will now return the correct structure distance when very far from it.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary explanation. It's clear that this bug fix will do this. |
||
"debugify.fix_explanation.mc-119417": "Stops player from sleeping when they change to spectator.", | ||
"debugify.fix_explanation.mc-119754": "Tells firework entities that players are not elytra flying if in spectator", | ||
"debugify.fix_explanation.mc-121706": "Entities with a ranged bow attack goal are forced to look at their target.", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixin should always match target class name:
LocateCommandMixin