feat: Gracefully handle panics, add --log flag #8
Conversation
Codecov ReportBase: 73.00% // Head: 71.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 73.00% 71.69% -1.32%
==========================================
Files 7 7
Lines 515 537 +22
==========================================
+ Hits 376 385 +9
- Misses 109 121 +12
- Partials 30 31 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
That's quite a bit of work to handle issues with Influx I guess? Are you having issues with database availability? |
Not really, I just found out that panics weren't handled in a separate goroutine from sending a bad payload, which may cause the server to crash. This fix will capture the panic as non-retryable errors (hence the need to mark only InfluxDB client errors as retryable). |
| @@ -13,6 +14,7 @@ var ( | |||
|
|
|||
| func init() { | |||
| pflag.StringVar(&listenAddr, "http.listenAddr", ":8080", "Address to listen on.") | |||
| pflag.Uint32Var(&logLevel, "log", 0, "Log level to use, defaults to 4 (INFO).") | |||
There was a problem hiding this comment.
Looks like it defaults to 0 (PANIC) to me.... 
Also, maybe document the log levels or link to logrus?
--logflag to change default log verbosity