Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Detail and AccountHistory ids Integer -> BigInteger #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aagnone3
Copy link

Trade IDs are now out of range for Integer


/**
* Created by irufus on 2/18/15.
*/
public class AccountHistory {
private Integer id;
private BigInteger id;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is a good idea to use BigInteger, why not just use String and we can adopt any future changes from Coinbase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants