Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added holes.pl, lists all open sockets, only meaningful if running in… #870

Merged
merged 3 commits into from
Feb 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions scripts/holes.pl
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
use Irssi;
use strict;
use warnings;

our $VERSION = "1.0.0";
our %IRSSI = (
authors => 'terminaldweller',
contact => 'https://terminaldweller.com',
name => 'holes',
description => 'gives a list of of the open sockets as an expando(this makes sense only if irssi is in a container)',
license => 'GPL3 or newer',
url => 'https://github.com/irssi/scripts.irssi.org',
);

Irssi::settings_add_int('misc', 'holes_frequency', 30000);
Irssi::settings_add_str('misc', 'holes_separator', '');
my $holes = "";
my $timeout;
my $holes_cmd = << 'HOLES_CMD';
lsof | grep socket | awk '{print $4}' | awk 'BEGIN{FS=":"}{print $2}' | tr -d [] | uniq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[] should be quoted as it can be a metachar depending on your shell

(maybe the pipe could be implemented in perl instead)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. ill go learn what the thing you just said means.

HOLES_CMD

sub uniq {
my %seen;
grep !$seen{$_}++, @_;
}

sub holes_sub {
my $result;
Irssi::timeout_remove($timeout);
my $output = `$holes_cmd`;
Copy link
Contributor

@ailin-nemui ailin-nemui Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be mindful, synchronous execution of command can stall irssi especially if you have a lot of open files

(maybe ss or netstat is faster)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont expect this to take long since running this script only makes sense if you are running it inside an applicatino container. The comments explicitly mention that.
But generally, you're right.

my $sep = Irssi::parse_special(Irssi::settings_get_str('holes_separator'));
my @lines = split /\n/, $output;
my @lines = uniq(@lines);

Check warning on line 34 in scripts/holes.pl

View workflow job for this annotation

GitHub Actions / test

"my" variable @lines masks earlier declaration in same scope
$holes = '';
$result = @lines;
foreach my $line (@lines) {
if ($result == "") {

Check warning on line 38 in scripts/holes.pl

View workflow job for this annotation

GitHub Actions / test

Mismatched operator
$result = $line
}
$result = $result.$sep.$line
terminaldweller marked this conversation as resolved.
Show resolved Hide resolved
}
# $result =~ s/^\s+//;
$holes= $result;
$timeout = Irssi::timeout_add_once(Irssi::settings_get_int('holes_frequency'), 'holes_sub' , undef);
}

Irssi::expando_create('holes', sub {
return $holes;
}, {});

$timeout = Irssi::timeout_add(Irssi::settings_get_int('holes_frequency'), 'holes_sub' , undef);
holes_sub();