Code review for 6.1.1 global stylesheet cache testing plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin should ONLY work under 6.1.1, where apparent caching issue was introduced.
Changes from using transient to WP_Object_Cache to store global stylesheet.
Overrides wp_enqueue_global_styles to reference hotfixed replacement.
Using Plain structure does not repro issue
Unable to repro in 5.8
Clearly identify what will result from community testing.
ironprogrammer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a testing plugin with the proposed updates from PR 3712.
See Trac 56970 (fix commentary starts here).
(Please excuse the whole
trunk=>mainthing, it IS intentional. Juggling branch names to get the PR to work 😉 )