Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dice so Nice + Monk's Token Bar - Public Rolls not working in 12.02 (fine in 12.01) #519

Closed
matt-duffy opened this issue Sep 8, 2024 · 5 comments

Comments

@matt-duffy
Copy link

Describe the bug
If I request a roll using dice so nice and monk's token bar 12.02 as a public roll, the 3d dice are never rolled and the result is not shown unless I (GM) click on the elipsis.

I have tested this with only dice so nice 5.0.5 and Monk's TokenBar 12.02 running and always get the same result. If I downgrade to 12.01 then it all works as expected, the 3 dice is rolled and the result is displayed.

To Reproduce
Steps to reproduce the behavior:

  1. Request a roll with Roll Mode "Public Roll", click the Request button
  2. User rolls from the chat card

Expected behavior

  1. 3d dice are rolled
  2. The result is automatically shown

Screenshots
GM Requests Roll:

2024-09-08_10-47-06.mp4

Player Rolls (no dice roll):

2024-09-08_10-47-30.mp4

GM has to click to show it:

2024-09-08_10-47-51.mp4

Please complete as much of the following information as possible:

  • Browser: Tested in Edge and Firefox
  • Foundry Version 12.331
  • System D&D 5e 3.3.1
  • Module version 12.02
  • Are there any errors in the console [e.g. press F12 and look for red text] - Not on GM or player side
  • Have you tried using Find the Culprit to make sure it isn't a module interaction. - As above have tested with only dice so nice and Monk's TokenBar running

Additional context
I did note that it looked like this issue had a fix in the last release, perhaps this caused it?

#494

@Vagabondluc
Copy link

I have this issue since im in v12 (end of june).

I thought at first it was midi-qol. But after playing some sessions without midi-qol, monk token bar was my second guess.

I dont know if it related to this issue, but rolls dont even seem to work after a while.

It super hard to diagnose because the issue is intermittent.

Anyways, monk token bar is disabled in my world right now and i dont have thoses issues anymore.

But i really miss monk token bar.

@ironmonk88
Copy link
Owner

Fixed in the latest version

@Vagabondluc
Copy link

image
image

image

I think i'm on the last version and i still have problems.

@matt-duffy
Copy link
Author

This seems to be fixed for me now, but now I have another issue that I will raise

@matt-duffy
Copy link
Author

Scrap that, my mistake, it is working fine for me, would be handy if you could set the minimum system version in the module though as my real server is still stuck on v3 D&D until a last couple of modules update and the latest version doesn't work in D&D v3.

Thanks for the great module! Dice so Nice and Monk's Token bar are my 2 most used far and away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants