New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolls not being revealed with Dice So Nice is active but not enabled. #494

Open

tposney opened this issue Jun 18, 2024 · 0 comments

Labels

fixed waiting for release

tposney commented Jun 18, 2024 •

edited

Loading

In foundry v11/v12 and dnd5e 3.2 (but not relevant).

When monks tests to reveal a roll it uses

const revealDice = game.dice3d ? game.settings.get("dice-so-nice", "immediatelyDisplayChatMessages") : true;

which causes a problem when dice so nice is active but not enabled. All of the revealDice tests could be replaced with

const revealDice = game.dice3d ? (game.settings.get("dice-so-nice", "immediatelyDisplayChatMessages") || !game.dice3d.isEnabled()) : true;

which will reveal the roll as required.

ironmonk88 added the fixed waiting for release label

matt-duffy mentioned this issue

Dice so Nice + Monk's Token Bar - Public Rolls not working in 12.02 (fine in 12.01) #519

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment