v3 Proof of Concept #199
v3 Proof of Concept #199
Conversation
jeremy-visionaid
force-pushed
the
3.0-poc-draft
branch
from
795f4f8 to
f4692b9
Compare
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="System.Collections.Immutable" Version="8.0.0" /> |
There was a problem hiding this comment.
I'll try to make time to do some tests later, but one small thing here - can these nuget references be conditionalized so they're only included for .NET Standard 2?
(refs comments in #123 about them being built in to .NET)
There was a problem hiding this comment.
@Numpsy Good call, I'd missed that a package was available for it for netstandard2.0.
| {0x00000010, "PIDSI_CHARCOUNT" }, | ||
| {0x00000012, "PIDSI_APPNAME" }, | ||
| {0x00000013, "PIDSI_DOC_SECURITY" } | ||
| }.ToImmutableDictionary(); |
There was a problem hiding this comment.
/ponders whether FrozenDictionary would work better than ImmutableDictionary here?
|
Can we get #204 into this branch? Though sayting that I see the change in the 3.0-draft branch but not here |
|
@Numpsy Ah yup, I already ported the code for VT_I8, but the branch was stale |
|
The v3 draft branch doesn't seem to contain #190 ? |
|
This has been superseded by merging to master |
Draft proof of concept for v3.0 (#194)