Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new backward compatible status field TAPDevice #304

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

guvenc
Copy link
Collaborator

@guvenc guvenc commented Feb 14, 2025

This backward compatible field is needed to support TAP devices which do not have PCI addresses and metalnet consumers can have a better way to use the TAP devices.

@guvenc guvenc requested a review from a team as a code owner February 14, 2025 14:03
@github-actions github-actions bot added enhancement New feature or request size/M labels Feb 14, 2025
@guvenc guvenc linked an issue Feb 14, 2025 that may be closed by this pull request
This backward compatible fiels is needed to support TAP devices
which do not have PCI addresses and metalnet consumers can
have a better way to use the TAP devices.

Signed-off-by: Guvenc Gulce <[email protected]>
@guvenc guvenc force-pushed the feature/api_change_tap_device_support branch from 7d46135 to 1e3769f Compare February 14, 2025 14:05
@guvenc guvenc requested a review from afritzler February 14, 2025 14:08
Copy link
Contributor

@byteocean byteocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@guvenc guvenc merged commit b6f01eb into main Feb 14, 2025
8 checks passed
@guvenc guvenc deleted the feature/api_change_tap_device_support branch February 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TAP devices
2 participants