Add development setup document and modify config files as needed #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
documentation
kasabe28
force-pushed
the
doc/development-setup
branch
from
e078585 to
437081e
Compare
balpert89
reviewed
Feb 15, 2024
balpert89
reviewed
Feb 15, 2024
kasabe28
force-pushed
the
doc/development-setup
branch
2 times, most recently
from
22776b4 to
17b80c3
Compare
kasabe28
force-pushed
the
doc/development-setup
branch
from
17b80c3 to
2f2d3e8
Compare
balpert89
reviewed
Feb 16, 2024
| @@ -15,6 +15,7 @@ namePrefix: apinetlet- | |||
| resources: | |||
| - ../rbac | |||
| - ../manager | |||
| - ../apinet-rbac | |||
There was a problem hiding this comment.
@afritzler I am not sure if this should be employed here - i can remember this should only be done when all components run together in the same cluster.
If this is the case, the inclusion of ./apinet-rbac should be done downstream as well depending of this, e.g. in the kind-specific kustomization configuration:
resources:
- github.com/ironcore-dev/ironcore-net/config/apinetlet/apinet-rbac?ref=437081e6eea333713fa75ce6ccf3a46025a8dac0
- github.com/ironcore-dev/ironcore-net/config/apinetlet/default?ref=437081e6eea333713fa75ce6ccf3a46025a8dac0
The same goes for metalnetlet-rbac
afritzler
requested changes
Feb 18, 2024
docs/development/setup.md
Outdated
| 1. Install ironcore-net API server and API services into the K8s cluster. | ||
|
|
||
| ```shell | ||
| make install APISERVER_IMG=<apiserver image> |
There was a problem hiding this comment.
It is common to set the variables before the deploy command. Can we change that for all the calls?
There was a problem hiding this comment.
removed steps for clusters other than kind
kasabe28
force-pushed
the
doc/development-setup
branch
from
5918212 to
4224960
Compare
afritzler
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes