Fix namespace deletion due to lacking protobuf #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
changed the title
NegotioatedSerializer to apiGroupInfo in apiserver
afritzler
force-pushed
the
fix/negotiated-serializer
branch
2 times, most recently
from
583db88 to
5753f18
Compare
afritzler
force-pushed
the
fix/negotiated-serializer
branch
from
5753f18 to
33cbb79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
NegotioatedSerializertoapiGroupInfoin apiserver. The missing protobuf serialization is causingnamespacesto be stuck in termination when deleted./ref kubernetes/kubernetes#86666
Fixes #178