Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implicit ip family type label when creating an IPAM ip object #339

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add implicit ip family type label when creating an IPAM ip object #339

merged 2 commits into from
Jun 10, 2024

Conversation

damyan
Copy link
Member

@damyan damyan commented Jun 10, 2024

No description provided.

@damyan damyan requested a review from aobort June 10, 2024 09:20
@damyan damyan marked this pull request as draft June 10, 2024 09:20
@github-actions github-actions bot added enhancement New feature or request size/XXL labels Jun 10, 2024
@damyan damyan marked this pull request as ready for review June 10, 2024 09:47
aobort
aobort approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@aobort aobort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damyan damyan merged commit 43de245 into main Jun 10, 2024
9 checks passed
@damyan damyan deleted the feature/add-family-type-label branch June 10, 2024 09:47
@damyan
Copy link
Member Author

damyan commented Jun 10, 2024

Label ip.ipam.metal.ironcore.dev/ip-family: IPv4/6 is now added with each IPAM ip creation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aobort aobort aobort approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damyan @aobort