Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Mobile improvements #255

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Update: Mobile improvements #255

merged 5 commits into from
Jan 30, 2025

Conversation

dg-ac
Copy link
Contributor

@dg-ac dg-ac commented Jan 26, 2025

Hi,

I've fixed/improved a few things that were a bit annoying in the mobile view:

  1. Removed ironcalc.com link: this was using too much horizontal space in the sheet container, hurting usability\
image
  1. Input on formatPicker was longer than dialog
image
  1. On formula bar, I've reduced the excessive distance between selected cell and the divider
image
  1. Updated hex colors to use the theme ones

Let me know if I need to change anything.

Best,
D

nhatcher
nhatcher requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@nhatcher nhatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request

webapp/IronCalc/src/components/formulabar.tsx Outdated Show resolved Hide resolved
@nhatcher nhatcher merged commit 282ed16 into main Jan 30, 2025
1 check passed
@nhatcher nhatcher deleted the fix/dani-mobile-improvements branch January 30, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhatcher nhatcher nhatcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg-ac @nhatcher