-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functions: fix route timeout #349
Conversation
ce72788
to
5cc2d32
Compare
So, here the thing, we need to have persisted models definitions out of code in order to have good enough user experience during upgrades from version X to version Y. Another question, if i would create a route before this patch and then will upgrade Along with that, this code doesn't actually validate if Mentions: https://open-iron.slack.com/archives/functions/p1480362602001126 |
Ideally, we shall have stable model definition by v1, and from there backward compatible changes only. This hasn't been discussed yet. We are still in the Alpha cycle where we all expect things to break often. Currently, routes whose configuration has
Indeed it doesn't. But also this PR is WIP. I shall align integer sizes once I regenerate client libraries. |
4a4f011
to
6a0a175
Compare
cli.DurationFlag{ | ||
Name: "timeout", | ||
Usage: "route timeout", | ||
Value: 30 * time.Second, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
60 or 30 seconds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should actually be 30, because that what it was before. I am reducing the default in the other package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Fix #339