This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
Support local editing with user fixture #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ironfish/website-testnet/EWYkYmTumWYG8JfVzMUqLPznnXhZ |
leanthebean
approved these changes
Dec 13, 2021
leanthebean
reviewed
Dec 13, 2021
|
Gonna merge this for now. We can revisit other options in the future but this will unblock anyone and keep our moving parts low for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've made the decision (see previous Login PR) to make some of our UI hang in a loading state until it hears back from Magic Link. This is good in non-local environments, but locally it's a bit of a PITA to use things.
Testing Plan
Make sure this doesn't change anything except locally.
Breaking Change
No, unless you set
NEXT_PUBLIC_LOCAL_USERto true in production.