Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable Settings #129

Merged
merged 83 commits into from
Jan 31, 2022
Merged

Editable Settings #129

merged 83 commits into from
Jan 31, 2022

Conversation

brekk
Copy link
Contributor

@brekk brekk commented Dec 8, 2021

Changes:

  • - 🧹 Removed API_KEY usage. It's a hold-over from a former age, and now it is dead.
  • - 🏋🏽 Added a new function in apiClient for updating a user. It's called (surprisingly) updateUser. It takes an object blob and passes it to the API via PUT.
  • - 🔧 Fixed a several bugs in useField which would cause it to infinitely re-render
  • - Field updates:
    • Disabled email
    • Graffiti with warning-on-touch
    • Split out Discord + Telegram into separate non-required fields.
    • Country Selector with no default
  • Wrote a bunch of smoke tests - but to aid readability, I have moved these changes to Add snapshot tests #164
  • - 🦾 Improved the behavior of hooks/useLogin so that it can be reloaded
  • - Updated /users/[id] to support picking tabs via query string: ?tab=settings

Testing Process:

  1. Make sure you can log in (use the leaderboard to verify whether you've already created a user on staging)
  2. Go to your user (click your username in the upper right). All of the tabs should still work, but now the settings tab should allow one to actually change values. (If you take a look at the network tab you should see the data verifies this) Change some values for fun / profit!
  3. You shouldn't be able to see other people's settings

@linear
Copy link

linear bot commented Dec 8, 2021

@vercel
Copy link

vercel bot commented Dec 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ironfish/website-testnet/Go5kmQZ75d4MKcdNc7bMEbvDZ2WC
✅ Preview: https://website-testnet-git-feature-iro-1337-editable-settings-ironfish.vercel.app

@brekk
Copy link
Contributor Author

brekk commented Dec 13, 2021

This PR will eventually also fix https://github.com/iron-fish/website-testnet/issues/131 (pending some changes on the backend)

@brekk brekk linked an issue Dec 13, 2021 that may be closed by this pull request
@brekk brekk force-pushed the feature/iro-1337-editable-settings branch from da1aba1 to a51ec83 Compare December 16, 2021 16:33
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brekk brekk merged commit f3e8fbe into master Jan 31, 2022
@brekk brekk deleted the feature/iro-1337-editable-settings branch January 31, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website username settings issue
2 participants