-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable Settings #129
Editable Settings #129
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ironfish/website-testnet/Go5kmQZ75d4MKcdNc7bMEbvDZ2WC |
6e23d35
to
cbb59e6
Compare
This PR will eventually also fix https://github.com/iron-fish/website-testnet/issues/131 (pending some changes on the backend) |
da1aba1
to
a51ec83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Changes:
API_KEY
usage. It's a hold-over from a former age, and now it is dead.apiClient
for updating a user. It's called (surprisingly)updateUser
. It takes an object blob and passes it to the API viaPUT
.useField
which would cause it to infinitely re-renderhooks/useLogin
so that it can be reloaded/users/[id]
to support picking tabs via query string:?tab=settings
Testing Process: