PopoverRef.close will destroy popover component

irohalab · Aug 18, 2024 · 1d47c6a · 1d47c6a
1 parent b84ee29
commit 1d47c6a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "deneb-ui",
-  "version": "4.1.2",
+  "version": "4.2.0",
   "scripts": {
     "ng": "ng",
     "start": "ng serve --project Deneb-UI-Demo",

diff --git a/projects/irohalab/deneb-ui/package.json b/projects/irohalab/deneb-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@irohalab/deneb-ui",
-  "version": "4.1.2",
+  "version": "4.2.0",
   "description": "Building blocks for mira-ui",
   "author": "Everett Summer",
   "license": "Apache-2.0",

diff --git a/projects/irohalab/deneb-ui/src/popover/popover-ref.ts b/projects/irohalab/deneb-ui/src/popover/popover-ref.ts
@@ -32,15 +32,10 @@ export class UIPopoverRef<T> {
         this._appRef.attachView(componentRef.hostView);
         this._popper = new Popper(refElement, componentElement, {
             placement: this.placement
-            // onCreate: (data) => {
-            //     console.log('onCreate', data);
-            // },
-            // onUpdate: (data) => {
-            //     console.log('onUpdate', data);
-            // }
         });
         this._disposeCallback = () => {
             this._appRef.detachView(componentRef.hostView);
+            componentRef.destroy();
         };
     }