fix bug in ssr

irohalab · Jul 28, 2024 · 116f877 · 116f877
1 parent d15f92e
commit 116f877
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "deneb-ui",
-  "version": "4.1.0",
+  "version": "4.1.1",
   "scripts": {
     "ng": "ng",
     "start": "ng serve --project Deneb-UI-Demo",

diff --git a/projects/irohalab/deneb-ui/package.json b/projects/irohalab/deneb-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@irohalab/deneb-ui",
-  "version": "4.1.0",
+  "version": "4.1.1",
   "description": "Building blocks for mira-ui",
   "author": "Everett Summer",
   "license": "Apache-2.0",

diff --git a/projects/irohalab/deneb-ui/src/dark-theme.service.ts b/projects/irohalab/deneb-ui/src/dark-theme.service.ts
@@ -18,7 +18,7 @@ export class DarkThemeService implements OnDestroy {
         return this._themeChangeSubject.asObservable();
     }
 
-    constructor(@Inject(PLATFORM_ID) platformId: object) {
+    constructor(@Inject(PLATFORM_ID) private platformId: object) {
         if (isPlatformBrowser(platformId)) {
             this.checkTheme();
             this.initGlobalListener();
@@ -37,7 +37,9 @@ export class DarkThemeService implements OnDestroy {
     }
 
     public ngOnDestroy(): void {
-        window.removeEventListener(EVENT_NAME, this._globalListenerInstance);
+        if (isPlatformBrowser(this.platformId)) {
+            window.removeEventListener(EVENT_NAME, this._globalListenerInstance);
+        }
     }
 
     private initGlobalListener(): void {