New popup on login page for restricted use message #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @JustinKyleJames |
|
yep thanks. Justin, let me know if any changes are needed. |
|
Consider a configuration setting... (perhaps even the whole string could be a configuration... Oh, could just test to see if the string is not-empty... and show it... we'd default to empty. Won't be merging into the main branch as-is. |
|
In my case the login page will never show so I'll have to rework that a bit but this is very good. It should give me enough to do what I need. |
connectbo
force-pushed
the
feature/pop-up
branch
from
9e259db to
4081076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes 1) new popup for restricted use message and 2) fix some positioning bug in the login wrapper