Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Allow parallel testing on NVIDIA GPUs #5467

Merged
merged 1 commit into from
Apr 16, 2021
Merged

[ci] Allow parallel testing on NVIDIA GPUs #5467

merged 1 commit into from
Apr 16, 2021

Conversation

antiagainst
Copy link
Contributor

@antiagainst antiagainst commented Apr 15, 2021 •
edited by GMNGeoffrey
Loading

This reverts #5163 and
#5166 as now buffer usage
is improved on Vulkan.

Related to #5162

@antiagainst
[ci] Allow parallel testing on NVIDIA GPUs
88ea919 
This reverts iree-org#5163 and
iree-org#5166 as now buffer usage
is improved on Vulkan.
@antiagainst antiagainst requested a review from GMNGeoffrey April 15, 2021 22:12
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
GMNGeoffrey
GMNGeoffrey approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@GMNGeoffrey GMNGeoffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the turing test passes. We can ignore the tool failure on the swiftshader test. That shouldn't be affected here and I double checked the cause didn't look suspicious (RPC timeout somewhere in the infra).

@antiagainst antiagainst merged commit 3eab154 into iree-org:main Apr 16, 2021
This was referenced Apr 16, 2021
Closed
Closed
Closed
Merged
GMNGeoffrey added a commit that referenced this pull request Apr 16, 2021
@GMNGeoffrey
Revert "[ci] Allow parallel testing on NVIDIA GPUs (#5467)"
9abbcfe 
This reverts commit 3eab154.
@GMNGeoffrey GMNGeoffrey mentioned this pull request Apr 16, 2021
Merged
GMNGeoffrey added a commit that referenced this pull request Apr 16, 2021
@GMNGeoffrey
Revert "[ci] Allow parallel testing on NVIDIA GPUs" (#5496)
6d0aae7 
I'm suspicious that this is the proximate cause of crashes we're seeing
while destroying the Vulkan device. We think
#2659 and
#2900 are the root cause, but
reverting for now to try to get us back to green.

Example failure, starting at the PR being reverted:
https://source.cloud.google.com/results/invocations/a3093172-ae55-43bb-956c-256bb726006f/targets/iree%2Fgcp_ubuntu%2Fcmake-bazel%2Flinux%2Fx86-turing%2Fmain/log

Reverts #5467
@antiagainst antiagainst deleted the parallel-tests branch September 5, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMNGeoffrey GMNGeoffrey GMNGeoffrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antiagainst @GMNGeoffrey