Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spirv] Migrate matmul pipeline test to linalg on tensors #5381

Merged
merged 2 commits into from
Apr 19, 2021
Merged

[spirv] Migrate matmul pipeline test to linalg on tensors #5381

merged 2 commits into from
Apr 19, 2021

Conversation

antiagainst
Copy link
Contributor

This is a step towards #5155.

@google-cla google-cla bot added the cla: yes label Apr 9, 2021
MaheshRavishankar
MaheshRavishankar requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@MaheshRavishankar MaheshRavishankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe hold off till we do a main -> google integrate. Just to be safe and not have to do multiple reverts.

@antiagainst
Copy link
Contributor Author

Is it safe to land now, @rsuderman?

@antiagainst antiagainst merged commit 7afbd4b into iree-org:main Apr 19, 2021
@hanhanW hanhanW mentioned this pull request Apr 19, 2021
Closed
@GMNGeoffrey GMNGeoffrey mentioned this pull request Apr 19, 2021
Merged
@antiagainst antiagainst linked an issue Apr 26, 2021 that may be closed by this pull request
Some lit tests should be fixed when migrating to Linalg on tensors #5155
Closed
@antiagainst antiagainst deleted the migrate-tests branch September 5, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanhanW hanhanW hanhanW approved these changes

@MaheshRavishankar MaheshRavishankar MaheshRavishankar approved these changes

@ThomasRaoux ThomasRaoux Awaiting requested review from ThomasRaoux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some lit tests should be fixed when migrating to Linalg on tensors
3 participants
@antiagainst @MaheshRavishankar @hanhanW