Merge HLOToHLO into HLOToHLOPreprocessing #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we want to fully merge HLOToHLO pass into HLOToHLOPreprocessing. It looks okay to me, what do you think? If it's a good idea, I can do it in this patch. For now just moving GatheToTorchIndexSelect pattern, which looks reasonable to me and this can unblock test on unidirectional_lstm. |
hanhanW
force-pushed
the
move-pattern
branch
2 times, most recently
from
e826d5c to
6ba7ed4
Compare
Some operations, like torch_index_select, can only live in their dispatch function in IREE. Merging some of patterns from HLOToHLO to earlier stage, so IREE can idetnfiy such of case. This also unblocks unidrectional_lstm test on vulkan-spirv and llvm-ir.
|
benvanik
approved these changes
Aug 5, 2020
Sounds good, let me merge the whole pass into HLOToHLOPreprocessing, and delete HLOToHLO pass. Will update the PR. |
hanhanW
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operations, like torch_index_select, can only live in their
dispatch function in IREE. Merging some of patterns from HLOToHLO to
earlier stage, so IREE can idetnfiy such of case.
This also unblocks unidrectional_lstm test on vulkan-spirv and llvm-ir.