[vm] Add support for SI64 to F32 casts #19455
Merged
+139
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashu123
requested changes
Dec 11, 2024
compiler/src/iree/compiler/Dialect/VM/Conversion/ArithToVM/Patterns.cpp
Outdated
Show resolved
Hide resolved
|
In the PR body is a bit misleading: |
|
@pashu123 I have auto-generated |
vinayakdsci
force-pushed
the
vm-add-si64f32-cast
branch
3 times, most recently
from
24f8c86 to
9dd5a3d
Compare
benvanik
approved these changes
Dec 12, 2024
pashu123
reviewed
Dec 13, 2024
vinayakdsci
force-pushed
the
vm-add-si64f32-cast
branch
from
9dd5a3d to
53eac6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to the VM for casting from
si64type tof32type.Enables the lowering of
arith.sitofp %arg0 : i64 to f32after demotion.