Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate LLVM at 3f0cc068cef26e820b3acbd21b3577817e4bf4ca #19387

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nithinsubbiah
Copy link
Collaborator

@nithinsubbiah nithinsubbiah requested review from bjacob and kuhar December 5, 2024 18:15
@nithinsubbiah nithinsubbiah marked this pull request as draft December 5, 2024 18:16
@nithinsubbiah nithinsubbiah marked this pull request as ready for review December 5, 2024 18:23
@bjacob
Copy link
Contributor

bjacob commented Dec 5, 2024

CI failure - I just triggered a rerun to see if it's just transient.

	test_sdxl_rocm_benchmark failed on attempt 1! Retrying!
	Traceback (most recent call last):
	  File "/home/esaimana/actions-runner-2/_work/iree/iree/venv/lib/python3.11/site-packages/pytest_check/plugin.py", line 41, in pytest_runtest_makereport
	    raise AssertionError(report.longrepr)
	AssertionError: FAILURE: check 338.0 <= 330.0: SDXL e2e benchmark time should not regress
	benchmark_sdxl_rocm.py:523 in test_sdxl_rocm_benchmark() -> check.less_equal(
	
	FAILURE: check 58.3 <= 53.0: SDXL punet f8 benchmark time should not regress
	FAILURE: check 15.8 <= 15.5: SDXL prompt encoder benchmark time should not regress

If this persists, we have to decide whether to accept the regression. @ScottTodd

@ScottTodd
Copy link
Member

Note that the PkgCI / Regression Test / test_regression_suite :: amdgpu_rocm_mi300_gfx942 job has been unstable a bit lately. I've seen multiple similar flakes... not sure if anyone has investigated or tried to stabilize

@bjacob
Copy link
Contributor

bjacob commented Dec 5, 2024

Indeed, from your link, I found this recent instance on main branch with similar timeouts by similar margins:
https://github.com/iree-org/iree/actions/runs/12150291953/job/33883074393

@bjacob
Copy link
Contributor

bjacob commented Dec 5, 2024

Run #2 just completed here, failed again with similar timeout error:
https://github.com/iree-org/iree/actions/runs/12185625006/job/33996379858?pr=19387

Since this is similar to what's already failing today on main, this doesn't need to block this integrate longer. Approving!

@bjacob bjacob merged commit 0f0cac5 into iree-org:main Dec 5, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants