Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a range inference overflow with util.align. #18808

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fixes a range inference overflow with util.align. #18808

merged 1 commit into from
Oct 17, 2024

Conversation

stellaraccident
Copy link
Collaborator

  • In the present state we were folding a non-analyzable util.align lhs to a constant zero because the next power of two of the maximal range is zero.
  • Detects overflow and will not infer a range.
  • Fixes some issues with a RHS of zero that were discovered when writing tests for this case (which isn't really valid but was asserting the compiler).

@stellaraccident stellaraccident mentioned this pull request Oct 17, 2024
Merged
@stellaraccident stellaraccident merged commit 929a7da into main Oct 17, 2024
39 checks passed
@stellaraccident stellaraccident deleted the users/stella/util_align_overflow branch October 17, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvanik benvanik benvanik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellaraccident @benvanik