[LLVMCPU] Enable tileDispatchUsingForall as default #18777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashu123
requested review from
hanhanW,
MaheshRavishankar and
benvanik
as code owners
pashu123
force-pushed
the
cpudefault
branch
2 times, most recently
from
f04f7e5 to
b8eeba4
Compare
MaheshRavishankar
approved these changes
Oct 22, 2024
hanhanW
reviewed
Oct 24, 2024
Comment on lines
+550
to
+556
| // TODO: Enable grouped convolution and depth wise pooling fusion. | ||
| // Rightnow, this is going through the default CPU pipeline and not through | ||
| // CONVTilingExpert. | ||
| if (isa<linalg::Conv2DNgchwFgchwOp, linalg::Conv2DNgchwGfchwOp, | ||
| linalg::PoolingNdhwcSumOp>(producer)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Do we have an issue for this?
There was a problem hiding this comment.
These originate from some onnx models. I will file an issue.
|
@ScottTodd This patch enables some of the tests in |
pashu123
added a commit
to pashu123/iree-test-suites
that referenced
this pull request
Oct 24, 2024
These xfails start passing as a part of iree-org/iree#18777 commit.
For onnx ops? I'm actually thinking about removing all the xfails for onnx ops in the iree-org/iree-test-suites repo, so we don't have tracking in two places: iree-org/iree-test-suites#35. This repo should definitely update the config file(s). |
Eliasj42
pushed a commit
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Elias Joseph <[email protected]>
pashu123
added a commit
that referenced
this pull request
Nov 12, 2024
Add an additional level of tiling, aka vector parallel to the CPU default pipeline. Some of the linalg op that is not specialized through any pipeline may hit a bufferization issue if passed through the default pipeline. Adding an extra level of tiling takes care of such cases. Removes some ops (disabled for producer fusion) from dispatch Region creation. They were added in #18777 . For more info: #18900
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
Add an additional level of tiling, aka vector parallel to the CPU default pipeline. Some of the linalg op that is not specialized through any pipeline may hit a bufferization issue if passed through the default pipeline. Adding an extra level of tiling takes care of such cases. Removes some ops (disabled for producer fusion) from dispatch Region creation. They were added in iree-org#18777 . For more info: iree-org#18900
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
Add an additional level of tiling, aka vector parallel to the CPU default pipeline. Some of the linalg op that is not specialized through any pipeline may hit a bufferization issue if passed through the default pipeline. Adding an extra level of tiling takes care of such cases. Removes some ops (disabled for producer fusion) from dispatch Region creation. They were added in iree-org#18777 . For more info: iree-org#18900 Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.