Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented caching with Azure containers using sccache #18466

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Implemented caching with Azure containers using sccache #18466

merged 1 commit into from
Sep 10, 2024

Conversation

Eliasj42
Copy link
Contributor

@Eliasj42 Eliasj42 commented Sep 9, 2024 •
edited by ScottTodd
Loading

ci-exactly: linux_x64_clang

@Eliasj42 Eliasj42 requested a review from ScottTodd as a code owner September 9, 2024 16:23
@Eliasj42 Eliasj42 marked this pull request as draft September 9, 2024 16:23
@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch from cc512fa to 3e44b1c Compare September 9, 2024 17:02
@saienduri
Copy link
Collaborator

saienduri commented Sep 9, 2024 •
edited
Loading

image

Do some of these have to be enabled?

@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch from 3e44b1c to f43f2ee Compare September 9, 2024 17:04
@ScottTodd
Copy link
Member

image

Do some of these have to be enabled?

I suggested that Elias start with linux_x64_clang. That is the simplest workflow and also one the main ones. I can help get other workflows and scripts updated once we have one working.

@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch 8 times, most recently from fa5bf58 to fb36bdb Compare September 9, 2024 20:41
@saienduri
Copy link
Collaborator

Looks like latest run is still not really utilizing cache:

image

Do we just need another run or something else?

@ScottTodd
Copy link
Member

Looks like latest run is still not really utilizing cache:
image

Do we just need another run or something else?

Something else... probably.

We've been chatting / debugging in the Slack thread all day :P. I just posted an update here: #18238 (comment)

@saienduri
Copy link
Collaborator

Ah I see, thanks for the update

@ScottTodd ScottTodd mentioned this pull request Sep 9, 2024
Closed
30 tasks
@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch 2 times, most recently from d541f67 to ddd661c Compare September 10, 2024 16:00
ScottTodd
ScottTodd reviewed Sep 10, 2024
View reviewed changes
.github/workflows/ci_linux_x64_clang.yml Outdated Show resolved Hide resolved
.github/workflows/ci_linux_x64_clang.yml Outdated Show resolved Hide resolved
@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch 6 times, most recently from 7e8d0fd to 1657227 Compare September 10, 2024 19:28
@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch from 1657227 to 0162633 Compare September 10, 2024 19:58
@Eliasj42 Eliasj42 marked this pull request as ready for review September 10, 2024 20:06
@Eliasj42 Eliasj42 requested a review from ScottTodd September 10, 2024 20:06
added ccache
1af8f7a 
Signed-off-by: Elias Joseph <[email protected]>
@Eliasj42 Eliasj42 force-pushed the shared/runner-cluster-migration-ccache branch from 0162633 to 1af8f7a Compare September 10, 2024 20:08
@Eliasj42 Eliasj42 changed the title added ccache Implemented caching with Azure containers using sccache Sep 10, 2024
@Eliasj42 Eliasj42 merged commit 6dc3610 into shared/runner-cluster-migration Sep 10, 2024
23 checks passed
@Eliasj42 Eliasj42 deleted the shared/runner-cluster-migration-ccache branch September 10, 2024 20:56
ScottTodd
ScottTodd approved these changes Sep 10, 2024
View reviewed changes
.github/workflows/ci_linux_x64_clang.yml
defaults:
run:
shell: bash
env:
BUILD_DIR: build
SCCACHE_AZURE_CONNECTION_STRING: "${{ secrets.AZURE_CCACHE_CONNECTION_STRING }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're having some offline discussions about readonly vs readwrite and PRs from the main repo and from forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eliasj42 @saienduri @ScottTodd