Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate base clang workflow to new Dockerfile. #18392

Merged

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Aug 28, 2024

Progress on #15332. This uses a new cpubuilder_ubuntu_jammy_x86_64 dockerfile from https://github.com/iree-org/base-docker-images.

This stops using the remote cache that is hosted on GCP. Build time without a cache is about 20 minutes on current runners, while build with a cache is closer to 10 minutes. Build time without a cache is closer to 28-30 minutes on new runners. We can try adding back a cache using GitHub or our own hosted storage.

I tried to continue using the previous cache during this transition period, but the gcloud command needs to run on the host, and I'd like to stop using the docker_run.sh script. I'm hoping we can keep folding away this sort of complexity by having the build machines run a dockerfile that includes key environment components like utility tools and any needed authorization/secrets (see #18238).

ci-exactly: linux_x64_clang

@ScottTodd ScottTodd added the infrastructure Relating to build systems, CI, or testing label Aug 28, 2024
@ScottTodd ScottTodd requested a review from marbre August 28, 2024 23:28
@ScottTodd
Copy link
Member Author

Since this stops using a cache and slows down some builds, I'll redirect this from main to a shared/staging branch. We can merge that branch once we switch to the new build cluster and configuring a replacement cache.

@ScottTodd ScottTodd changed the base branch from main to shared/runner-cluster-migration August 29, 2024 18:32
@ScottTodd ScottTodd marked this pull request as ready for review August 29, 2024 18:36
@ScottTodd ScottTodd merged commit 125646f into shared/runner-cluster-migration Aug 29, 2024
23 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/ci_linux_x64_clang branch August 29, 2024 20:12
saienduri pushed a commit that referenced this pull request Sep 12, 2024
Progress on #15332. This uses a
new `cpubuilder_ubuntu_jammy_x86_64` dockerfile from
https://github.com/iree-org/base-docker-images.

This stops using the remote cache that is hosted on GCP. Build time
_without a cache_ is about 20 minutes on current runners, while build
_with a cache_ is closer to 10 minutes. Build time without a cache is
closer to 28-30 minutes on new runners. We can try adding back a cache
using GitHub or our own hosted storage.

I tried to continue using the previous cache during this transition
period, but the `gcloud` command needs to run on the host, and I'd like
to stop using the `docker_run.sh` script. I'm hoping we can keep folding
away this sort of complexity by having the build machines run a
dockerfile that includes key environment components like utility tools
and any needed authorization/secrets (see
#18238).

ci-exactly: linux_x64_clang
saienduri pushed a commit that referenced this pull request Sep 12, 2024
Progress on #15332. This uses a
new `cpubuilder_ubuntu_jammy_x86_64` dockerfile from
https://github.com/iree-org/base-docker-images.

This stops using the remote cache that is hosted on GCP. Build time
_without a cache_ is about 20 minutes on current runners, while build
_with a cache_ is closer to 10 minutes. Build time without a cache is
closer to 28-30 minutes on new runners. We can try adding back a cache
using GitHub or our own hosted storage.

I tried to continue using the previous cache during this transition
period, but the `gcloud` command needs to run on the host, and I'd like
to stop using the `docker_run.sh` script. I'm hoping we can keep folding
away this sort of complexity by having the build machines run a
dockerfile that includes key environment components like utility tools
and any needed authorization/secrets (see
#18238).

ci-exactly: linux_x64_clang
Signed-off-by: saienduri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants